Revert "feat(browser): Add ContextLines integration for html-embedded JS stack frames (#8670)"
#8680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Jul 31, 2023
|
FYI just merge this even with flaky test detector failing, we don't care 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So... Aside from some smaller things from #8670 that need fixing, I realized that the limitation around being off by "one or two" I already mentioned in the original PR is really problematic. Browsers don't return exact copies of the raw html in any JS API (
window.documentElement.inner|outerHTML,XMLSerializer). For example, they omit line breaks or spaces between<html>or<head>. Furthermore, they apply a lot more modifications.For now, I'll revert. Let's discuss if we move forward with a "best effort" solution or drop this.
ref #8656