Skip to content

fix(react): Add support for basename option of createBrowserRouter #8457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix(react): Add support for basename option of createBrowserRouter #8457

merged 2 commits into from
Jul 5, 2023

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jul 5, 2023 •
edited
Loading

Fixes: #8413

Passes basename option to matchRoutes we use to generate branches correctly, while updating pageload transactions and starting navigation transactions.

mydea
mydea reviewed Jul 5, 2023
View reviewed changes
@AbhiPrasad AbhiPrasad merged commit b48bc08 into develop Jul 5, 2023
@AbhiPrasad AbhiPrasad deleted the onur/react-router-basename branch July 5, 2023 16:05
@onurtemizkan onurtemizkan mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If the basename option is used with React Router 6 transactions are not created for navigation events.
3 participants
@onurtemizkan @mydea @AbhiPrasad