Skip to content

fix(tracing): Export key tracing types from node and browser SDKs #7593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 23, 2023
Merged

fix(tracing): Export key tracing types from node and browser SDKs #7593

merged 5 commits into from
Mar 23, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 23, 2023

With the future deprecation of @sentry/tracing, some types require re-exporting from the browser and node packages.

AbhiPrasad
AbhiPrasad reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update core to prevent exporting stripUrlQueryAndFragment or are we doing that in a follow up PR?

@timfish
Copy link
Collaborator Author

timfish commented Mar 23, 2023 •
edited
Loading

Should we update core to prevent exporting stripUrlQueryAndFragment or are we doing that in a follow up PR?

Ah yes, I'll remove that and TRACEPARENT_REGEXP from the core exports in this PR...

@AbhiPrasad AbhiPrasad merged commit c5f8e48 into getsentry:develop Mar 23, 2023
@timfish timfish deleted the feat/tracing/export-more-types branch March 23, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad