Skip to content

fix(sveltekit): Termporarily disable serverside load tracing #7587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Mar 23, 2023

We discovered that our serverside handleLoadWithSentry wrapper caused two distinct transactions being created on page loads - one for the page load request and one for the load function (if one exists for that page). This shouldn't happen. We need to investigate how to fix this.

As a short-term solution, we disable tracing on the serverside load wrapper to avoid quota usage increase for our users.

Note: I basically removed the trace call and added back the error reporting logic. However, I adjusted types to accept ServerLoad and Load functions as discovered in #7581

ref #7526

@Lms24 Lms24 requested a review from AbhiPrasad March 23, 2023 10:39
@Lms24 Lms24 self-assigned this Mar 23, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 71.66 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.87 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.92 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.09 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.33 KB (+0.08% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.39 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.53 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.06 KB (+0.06% 🔺)

@Lms24 Lms24 merged commit f1128bd into develop Mar 23, 2023
@Lms24 Lms24 deleted the lms/sveltekit-disable-server-load-trace branch March 23, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants