Skip to content

ref(core): Remove guards around scope usage #7554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

AbhiPrasad
Copy link
Member

Let's reduce some bundle size!

Now that #7551 merged in, we can remove guards around using the scope.

It's not a huge deal in node packages, so we don't have to go in and change anything there, but we can have some byte savings in our browser packages, so let's save!

Starting with core, then will do the rest of the packages in other PRs when I get time.

@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 March 21, 2023 14:37
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.49 KB (-0.21% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 63.7 KB (-0.24% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.17 KB (-0.1% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.74 KB (-0.32% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.63 KB (-0.15% 🔽)
@sentry/browser - Webpack (minified) 71.94 KB (-0.25% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.67 KB (-0.14% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.01 KB (-0.09% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.79 KB (-17.71% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (-0.11% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (-0.05% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.42 KB (-0.04% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.97 KB (-0.03% 🔽)

@AbhiPrasad AbhiPrasad merged commit 2738b5f into develop Mar 21, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-core-scope-allowed branch March 21, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants