Skip to content

fix(replay): Ensure network breadcrumbs have all data #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 16, 2023

We actually noticed that the recent change to enrich the replay breadcrumbs doesn't work as expected.
The reason is that we weren't actually listening to the breadcrumb, but actually doing our own instrumentation.

This refactors this to fully use the new breadcrumb hook for this whole functionality. It also adds a bunch of tests to ensure this actually works as expected.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Mar 16, 2023
@mydea mydea requested review from billyvg and Lms24 March 16, 2023 17:34
@mydea mydea self-assigned this Mar 16, 2023
@mydea mydea force-pushed the fn/replay-network-breadcrumb branch from ec4d094 to 07db898 Compare March 17, 2023 07:45
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.49 KB (+0.17% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 63.56 KB (+0.3% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.11 KB (+0.23% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.63 KB (+0.36% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.68 KB (+0.17% 🔺)
@sentry/browser - Webpack (minified) 72.17 KB (+0.28% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.72 KB (+0.18% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 52.05 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 33.78 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.14 KB (+0.13% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44 KB (+0.33% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.07 KB (+0.35% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.22 KB (+0.27% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.3 KB (+0.33% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea mydea force-pushed the fn/replay-network-breadcrumb branch from dd9b2a9 to a712cb4 Compare March 17, 2023 11:05
@mydea mydea force-pushed the fn/replay-network-breadcrumb branch from a712cb4 to e9ce530 Compare March 17, 2023 12:46
@mydea mydea enabled auto-merge (squash) March 17, 2023 13:25
@mydea mydea merged commit 4a6256e into develop Mar 17, 2023
@mydea mydea deleted the fn/replay-network-breadcrumb branch March 17, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants