feat(core): emit beforeEnvelope hook
#7448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 14, 2023
AbhiPrasad
requested changes
Mar 14, 2023
packages/core/src/transports/base.ts
Outdated
|
|
||
| function send(envelope: Envelope): PromiseLike<void | TransportMakeRequestResponse> { | ||
| const filteredEnvelopeItems: EnvelopeItem[] = []; | ||
|
|
||
| // Drop rate limited items from envelope | ||
| forEachEnvelopeItem(envelope, (item, type) => { | ||
| if (client && client.emit) { | ||
| client.emit('beforeEnvelope', envelope); |
There was a problem hiding this comment.
shouldn't this be called above forEachEnvelopeItem?
There was a problem hiding this comment.
Ah right, idk why I placed it here but yes, it def should be. Do I even need to feature check here btw, can I just client.emit...?
There was a problem hiding this comment.
emit may be unavailable when using a custom client, so until v8 we need to guard this, sadly!
AbhiPrasad
changed the title
beforeEnvelope hook
mydea
approved these changes
Mar 14, 2023
AbhiPrasad
approved these changes
Mar 14, 2023
|
@AbhiPrasad @mydea |
|
Tests are too flaky 😭 |
|
hehe yeah, I have been restarting them 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit beforeEnvelope event on the client when sending event.