Skip to content

ci: Upgrade size-limit #7371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ci: Upgrade size-limit #7371

wants to merge 2 commits into from

Conversation

AbhiPrasad
Copy link
Member

As part of #7366 this PR upgrades our size-limit library.

It also goes ahead and upgrade webpack usage throughout the codebase to use the latest webpack 5 version so everything is synced up.

@AbhiPrasad
Copy link
Member Author

Although #7366 was closed, we can still merge this in!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.88 KB (+3.82% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.2 KB (-0.5% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.61 KB (+4.58% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.29 KB (-0.38% 🔽)
@sentry/browser - Webpack (gzipped + minified) 20.56 KB (+0.29% 🔺)
@sentry/browser - Webpack (minified) 62.32 KB (-6.98% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.6 KB (+0.36% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.47 KB (-1.67% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.26 KB (+3.68% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.75 KB (+4.82% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.41 KB (+3.02% 🔺)
@sentry/replay - Webpack (gzipped + minified) 37.56 KB (+1.08% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.82 KB (+3.15% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.86 KB (+3% 🔺)

@AbhiPrasad AbhiPrasad requested review from a team, mydea and lforst and removed request for a team March 8, 2023 10:10
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess the measurement changes are results of slightly different size measurement methodologies?

@AbhiPrasad
Copy link
Member Author

Nice! I guess the measurement changes are results of slightly different size measurement methodologies?

It seems like this is the case, but I'm going to dig in and investigate more.

@AbhiPrasad
Copy link
Member Author

Gonna close this for now to come back to

@AbhiPrasad AbhiPrasad closed this Mar 13, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-webpack branch March 13, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants