Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 21, 2023

Adds an integration test that replays are continuously send every {flushDelay} seconds, even if page activity is ongoing.

Note: I also needed to update the non-browser-specific snapshots, and added this to the script as well.

@mydea mydea added Type: Tests Package: replay Issues related to the Sentry Replay SDK labels Feb 21, 2023
@mydea mydea requested review from billyvg and Lms24 February 21, 2023 13:37
@mydea mydea self-assigned this Feb 21, 2023
@@ -28,7 +28,7 @@
"test:cjs": "PW_BUNDLE=cjs yarn test",
"test:esm": "PW_BUNDLE=esm yarn test",
"test:ci": "playwright test ./suites --browser='all' --reporter='line'",
"test:update-snapshots": "yarn test --update-snapshots --browser='all'"
"test:update-snapshots": "yarn test --update-snapshots --browser='all' && yarn test --update-snapshots"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

@mydea mydea merged commit b1b249b into develop Feb 22, 2023
@mydea mydea deleted the fn/replay-test-flushing branch February 22, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants