Skip to content

test(replay): Test replay recording across multiple pages and navigations #7212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 17, 2023

This PR adds a Playwright integration test to test replay recording data across multiple pages, therefore, kind of simulating an actual user session. Specifically, we check that for each navigation that we send

  • the correct performance spans
  • the correct breadcrumbs
  • correct full and incremental DOM snapshots

To properly test multi-page app navigations, this PR modifies our playwright setup so that we can now have multiple html pages in one test case (see adjusted README section, how this works).

Given that #7145 made snapshot testing easier, I opted to snapshot-test the DOM checkouts and updates.

ref #7044

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.05 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 62.14 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.68 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 55.29 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.41 KB (0%)
@sentry/browser - Webpack (minified) 66.73 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.44 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.78 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.93 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.57 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 36.78 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.2 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.8 KB (-0.01% 🔽)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is really cool! Great test to really check actual user behavior 🎉

@Lms24 Lms24 force-pushed the lms/replay-pw-multi-page branch from e3b53d6 to 9fe6f02 Compare February 17, 2023 11:13
@Lms24 Lms24 merged commit afffdac into develop Feb 17, 2023
@Lms24 Lms24 deleted the lms/replay-pw-multi-page branch February 17, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants