Skip to content

test(integration): Add support for snapshots in integration tests #7145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2023
Merged

test(integration): Add support for snapshots in integration tests #7145

merged 5 commits into from
Feb 13, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 10, 2023

  • adds yarn test:update-snapshots script to update snapshots easily. This will run tests across all browsers and update the snapshots accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023 •
edited
Loading

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR f7c0a2f 79.31 ms 98.63 ms +19.32 ms +24.36 % 125.45 ms +46.14 ms +58.17 %
Previous cb19818 71.11 ms 90.74 ms +19.63 ms +27.60 % 128.27 ms +57.16 ms +80.38 %
CLS This PR f7c0a2f 0.06 ms 0.06 ms -0.00 ms -0.04 % 0.06 ms +0.00 ms +0.09 %
Previous cb19818 0.06 ms 0.06 ms +0.00 ms +0.46 % 0.06 ms +0.00 ms +0.46 %
CPU This PR f7c0a2f 18.10 % 18.91 % +0.81 pp +4.50 % 24.47 % +6.37 pp +35.21 %
Previous cb19818 12.50 % 12.42 % -0.08 pp -0.62 % 24.45 % +11.95 pp +95.64 %
JS heap avg This PR f7c0a2f 1.94 MB 2.05 MB +110.4 kB +5.69 % 2.86 MB +921.47 kB +47.47 %
Previous cb19818 1.94 MB 1.99 MB +48.2 kB +2.48 % 3.02 MB +1.07 MB +55.35 %
JS heap max This PR f7c0a2f 2.3 MB 2.58 MB +272.82 kB +11.84 % 3.36 MB +1.06 MB +45.86 %
Previous cb19818 2.31 MB 2.56 MB +255.3 kB +11.07 % 4.51 MB +2.21 MB +95.74 %
netTx This PR f7c0a2f 0 B 0 B 0 B n/a 2.23 kB +2.23 kB n/a
Previous cb19818 0 B 0 B 0 B n/a 2.52 kB +2.52 kB n/a
netRx This PR f7c0a2f 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous cb19818 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR f7c0a2f 0 0 0 n/a 1 +1 n/a
Previous cb19818 0 0 0 n/a 1 +1 n/a
netTime This PR f7c0a2f 0.00 ms 0.00 ms 0.00 ms n/a 207.30 ms +207.30 ms n/a
Previous cb19818 0.00 ms 0.00 ms 0.00 ms n/a 111.50 ms +111.50 ms n/a

Previous results on branch: develop
RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
cb19818+57.16 ms+0.00 ms+11.95 pp+1.07 MB+2.21 MB+2.52 kB+41 B+1+111.50 ms
ee301c3+71.07 ms-0.00 ms+12.64 pp+1.07 MB+2.22 MB+2.55 kB+41 B+1+94.67 ms
93c4759+61.10 ms-0.00 ms+12.72 pp+1.08 MB+2.19 MB+2.57 kB+41 B+1+116.75 ms
274f489+63.60 ms-0.00 ms+11.56 pp+1.08 MB+2.2 MB+2.56 kB+41 B+1+116.60 ms
4827b60+58.67 ms+0.00 ms+18.38 pp+1.07 MB+2.22 MB+2.6 kB+41 B+1+91.21 ms
c3806eb+79.85 ms-0.00 ms+12.10 pp+1.05 MB+2.16 MB+2.54 kB+41 B+1+93.58 ms
b49d9f7+52.79 ms-0.00 ms+15.46 pp+1.07 MB+2.21 MB+2.59 kB+41 B+1+70.48 ms
7e57cb7+47.89 ms+0.00 ms+10.59 pp+1.09 MB+2.21 MB+2.59 kB+41 B+1+72.93 ms
538c3a6+63.63 ms+0.00 ms+14.14 pp+1.07 MB+2.16 MB+2.6 kB+41 B+1+112.08 ms
fc7b716+52.44 ms+0.00 ms+14.74 pp+1.09 MB+2.21 MB+2.68 kB+41 B+1+89.64 ms
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Mon, 13 Feb 2023 13:49:57 GMT

@billyvg billyvg force-pushed the test-replay-add-snapshot-tests branch from 47a4ea7 to 45137d3 Compare February 10, 2023 15:44
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.07 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 62.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.7 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.34 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.43 KB (+0.01% 🔺)
@sentry/browser - Webpack (minified) 66.78 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.46 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.99 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.24 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.49 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 36.89 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.17 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.73 KB (0%)

@billyvg
test(integration): Add support for snapshots in integration tests
e21fe4f 
* adds `yarn test:update-snapshots` script to update snapshots easily. This will run tests across all browsers and update the snapshots accordingly.
@billyvg
update script
2ec2598
@billyvg billyvg force-pushed the test-replay-add-snapshot-tests branch from 041d09e to 2ec2598 Compare February 10, 2023 18:15
@billyvg billyvg marked this pull request as ready for review February 10, 2023 21:00
@billyvg billyvg requested a review from Lms24 February 10, 2023 21:00
@billyvg billyvg mentioned this pull request Feb 10, 2023
Merged
billyvg
billyvg commented Feb 13, 2023
View reviewed changes
@billyvg billyvg merged commit 2c514ed into develop Feb 13, 2023
@billyvg billyvg deleted the test-replay-add-snapshot-tests branch February 13, 2023 20:15
AbhiPrasad pushed a commit that referenced this pull request Feb 14, 2023
@billyvg @AbhiPrasad
test(integration): Add support for snapshots in integration tests (#7145
4c82d70 
)

* adds `yarn test:update-snapshots` script to update snapshots easily. This will run tests across all browsers and update the snapshots accordingly.
ramchaik pushed a commit to ramchaik/sentry-javascript that referenced this pull request Feb 14, 2023
@billyvg @ramchaik
test(integration): Add support for snapshots in integration tests (ge…
839daad 
…tsentry#7145)

* adds `yarn test:update-snapshots` script to update snapshots easily. This will run tests across all browsers and update the snapshots accordingly.
@Lms24 Lms24 mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @Lms24