Skip to content

fix(replay): Export Replay from Sentry namespace in full CDN bundle #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 9, 2023

To be consistent with export namespaces, we want the Replay integration to be accesible under Sentry.Replay in the full CDN bundles. This is backwards compatible as we still permit Sentry.Integrations.Replay as well. We can remove it in v8.

With this change, both CDN bundles containing replay (sdk+tracing+replay and sdk+replay) export from Sentry.Replay. Only the addon bundle, which we already deprecated and don't mention in the docs anymore will only be available i nSentry.Integrations.Replay.

@Lms24 Lms24 requested a review from mydea February 9, 2023 14:41
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR e9c799b 89.57 ms 121.60 ms +32.02 ms +35.75 % 140.30 ms +50.72 ms +56.63 %
Previous fc7b716 87.40 ms 117.55 ms +30.15 ms +34.50 % 139.84 ms +52.44 ms +60.00 %
CLS This PR e9c799b 0.06 ms 0.06 ms -0.00 ms -0.35 % 0.06 ms -0.00 ms -0.43 %
Previous fc7b716 0.06 ms 0.06 ms -0.00 ms -0.05 % 0.06 ms +0.00 ms +0.17 %
CPU This PR e9c799b 22.28 % 21.74 % -0.54 pp -2.43 % 38.25 % +15.96 pp +71.64 %
Previous fc7b716 23.43 % 21.43 % -2.00 pp -8.52 % 38.17 % +14.74 pp +62.91 %
JS heap avg This PR e9c799b 1.94 MB 2 MB +61.55 kB +3.17 % 3.03 MB +1.09 MB +56.25 %
Previous fc7b716 1.94 MB 2.06 MB +116.41 kB +6.00 % 3.03 MB +1.09 MB +56.28 %
JS heap max This PR e9c799b 2.3 MB 2.56 MB +255.16 kB +11.08 % 4.5 MB +2.2 MB +95.36 %
Previous fc7b716 2.3 MB 2.58 MB +271.73 kB +11.79 % 4.51 MB +2.21 MB +95.72 %
netTx This PR e9c799b 0 B 0 B 0 B n/a 2.61 kB +2.61 kB n/a
Previous fc7b716 0 B 0 B 0 B n/a 2.68 kB +2.68 kB n/a
netRx This PR e9c799b 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous fc7b716 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR e9c799b 0 0 0 n/a 1 +1 n/a
Previous fc7b716 0 0 0 n/a 1 +1 n/a
netTime This PR e9c799b 0.00 ms 0.00 ms 0.00 ms n/a 94.97 ms +94.97 ms n/a
Previous fc7b716 0.00 ms 0.00 ms 0.00 ms n/a 89.64 ms +89.64 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
fc7b716+52.44 ms+0.00 ms+14.74 pp+1.09 MB+2.21 MB+2.68 kB+41 B+1+89.64 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 09 Feb 2023 14:43:10 GMT

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.06 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.42 KB (0%)
@sentry/browser - Webpack (minified) 66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.97 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.23 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.28 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 36.7 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 59.93 KB (-0.02% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.48 KB (0%)

@Lms24 Lms24 merged commit a9bf858 into develop Feb 9, 2023
@Lms24 Lms24 deleted the lms-fix-replay-full-bundle-export branch February 9, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants