Skip to content

fix(tests): Use the default Playwright timeouts. #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jan 19, 2023

Resolves: #6848
Resolves: #6872

Updating Playwright configurations to use the default 30 seconds, instead of 12 seconds configured. Not sure why we decreased the test timeout in the first place.

The case in #6848 happens randomly in any test in the same file, so I suspect this is just about the shortened timeout, rather than certain implementation / test that trigger flaking.

Testing here to check if there is a hanging test that hits the default 30 seconds.


Edit: No flakes for #6848 or #6872 after 9 CI trials on this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.83 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.48 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.79 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.22 KB (0%)
@sentry/browser - Webpack (minified) 66.19 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.25 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.48 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.75 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.03 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.26 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.04 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.52 KB (-0.01% 🔽)

@onurtemizkan onurtemizkan marked this pull request as ready for review January 19, 2023 15:39
@onurtemizkan onurtemizkan changed the title chore(tests): Use the default Playwright timeouts. fix(tests): Use the default Playwright timeouts. Jan 19, 2023
@onurtemizkan onurtemizkan force-pushed the onur/playwright-default-timeouts branch from 0aa8847 to d1ad6f1 Compare January 19, 2023 16:58
@onurtemizkan onurtemizkan force-pushed the onur/playwright-default-timeouts branch from d1ad6f1 to e42bbdc Compare January 20, 2023 16:42
@AbhiPrasad AbhiPrasad merged commit 7005646 into master Jan 23, 2023
@AbhiPrasad AbhiPrasad deleted the onur/playwright-default-timeouts branch January 23, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: Remix test fails with page.goto: Navigation failed because page was closed! [Flaky CI]: Remix inject sentry-trace & baggage
2 participants