Skip to content

Conversation

@nevir
Copy link
Contributor

@nevir nevir commented Jul 30, 2016

Addresses #600

Expose a normalizePath option that can be used to modify stack trace filenames and culprits before they are sent up to Sentry. Handy for stripping off dynamic path prefixes, etc.


This change is Reviewable

nevir and others added 3 commits July 30, 2016 20:27
Expose a `normalizePath` option that can be used to modify stack trace filenames and culprits before they are sent up to Sentry. Handy for stripping off dynamic path prefixes, etc.
@igrayson
Copy link
Contributor

Updated this again

@dcramer
Copy link
Member

dcramer commented Sep 7, 2016

I like this idea, but I'm going to push for doing this server side (re: getsentry/sentry#4090). We can implement controls on the server to describe simple patterns which can be stripped.

Additionally, if we really need this on the client, it might be worthwhile to support prefixes like sentry-php does.

@nevir
Copy link
Contributor Author

nevir commented Sep 7, 2016

Hmm, well, in our case we've got information that would be difficult to convoy via a server side transform (platform)

This is a react native app that runs on iOS and Android, and makes use of code push to deploy JS bundle updates. Both platforms end up with a file named main.jsbundle, but we need to be able to disambiguate those for source mapping (each platform has slightly different compiled JS source).

We're making use of this transform to rewrite it to main.ios.jsbundle etc (and upload source maps accordingly). Does/will sentry server support per-platform maps?

@kamilogorek
Copy link
Contributor

Agree with @dcramer that this should be done on the server-side.
Closing this issue for now, but please feel free to continue discussion and reopen it if necessary.

@benvinegar
Copy link
Contributor

@kamilogorek So, some background. This has become an increasingly important pattern and ... while in 2016 we were having discussions about doing this on the server, I don't know that that's going to happen anytime soon.

I'm willing to revisit this. Or as @dcramer also suggests, just having a top-level path prefix option that does the job for you. This issue isn't critical, as this can be done currently using dataCallback; it's just not super convenient and error prone (bad).

@kamilogorek
Copy link
Contributor

kamilogorek commented Sep 12, 2017

Prefixes sounds good and should be rather easy to integrate here.
For a reference: https://docs.sentry.io/clients/php/config/

Created an issue for this task #1036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants