-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
normalizePath option #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalizePath option #670
Conversation
Expose a `normalizePath` option that can be used to modify stack trace filenames and culprits before they are sent up to Sentry. Handy for stripping off dynamic path prefixes, etc.
|
Updated this again |
|
I like this idea, but I'm going to push for doing this server side (re: getsentry/sentry#4090). We can implement controls on the server to describe simple patterns which can be stripped. Additionally, if we really need this on the client, it might be worthwhile to support prefixes like sentry-php does. |
|
Hmm, well, in our case we've got information that would be difficult to convoy via a server side transform (platform) This is a react native app that runs on iOS and Android, and makes use of code push to deploy JS bundle updates. Both platforms end up with a file named We're making use of this transform to rewrite it to |
|
Agree with @dcramer that this should be done on the server-side. |
|
@kamilogorek So, some background. This has become an increasingly important pattern and ... while in 2016 we were having discussions about doing this on the server, I don't know that that's going to happen anytime soon. I'm willing to revisit this. Or as @dcramer also suggests, just having a top-level path prefix option that does the job for you. This issue isn't critical, as this can be done currently using |
|
Prefixes sounds good and should be rather easy to integrate here. Created an issue for this task #1036 |
Addresses #600
Expose a
normalizePathoption that can be used to modify stack trace filenames and culprits before they are sent up to Sentry. Handy for stripping off dynamic path prefixes, etc.This change is