Skip to content

Update react-native default pathStrip regex (fixes #665) #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Jul 27, 2016

cc @mattrobenolt


This change is Reviewable

@benvinegar
Copy link
Contributor Author

This regex is far more liberal than before, and would break if you had x.app as a generic subfolder in your project directory structure, but I think that is a better risk than trying to match on the exact path (which frequently changes between iOS releases).

@benvinegar
Copy link
Contributor Author

cc @nevir

@macqueen
Copy link

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@benvinegar benvinegar merged commit 95bbaa7 into master Jul 28, 2016
@benvinegar benvinegar deleted the update-rn-regex branch July 28, 2016 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants