Skip to content

ref(replay): Enable naming-convention EsLint rule #6419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 5, 2022

This PR re-activates the @typescript-eslint/naming-convention rule which ensures that all private class members are prefixed with _.

ref #6323

@Lms24 Lms24 requested review from billyvg and mydea December 5, 2022 17:37
@Lms24 Lms24 changed the title ref(replay): Re-activate naming-convention EsLint rule ref(replay): Enable naming-convention EsLint rule Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.6 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.13 KB (0%)
@sentry/browser - Webpack (minified) 65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.01 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.44 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.57 KB (-0.31% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.23 KB (+0.06% 🔺)

@Lms24 Lms24 force-pushed the lms-replay-eslint-naming-convention branch from bd6096b to 9ae0002 Compare December 6, 2022 10:45
@Lms24 Lms24 merged commit 7e05eb4 into master Dec 6, 2022
@Lms24 Lms24 deleted the lms-replay-eslint-naming-convention branch December 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants