-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[replay] Linting & code quality alignments #6323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm going to remove the h/t @lobsterkatie for bringing this up. |
amazing, this is great! |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This is one more step of #6323. Note that this also renames/moves a few things to make more sense.
This is one more step of #6323. Note that this also renames/moves a few things to make more sense.
This is one more step of #6323. Note that this also renames/moves a few things to make more sense. wip Apply suggestions from code review Co-authored-by: Billy Vong <[email protected]>
This is one more step of #6323. Note that this also renames/moves a few things to make more sense. wip Apply suggestions from code review Co-authored-by: Billy Vong <[email protected]>
This is one more step of #6323. Note that this also renames/moves a few things to make more sense. wip Apply suggestions from code review Co-authored-by: Billy Vong <[email protected]>
This is one more step of #6323. Note that this also renames/moves a few things to make more sense. wip Apply suggestions from code review Co-authored-by: Billy Vong <[email protected]>
This is one more step of #6323. Note that this also renames/moves a few things to make more sense. wip Apply suggestions from code review Co-authored-by: Billy Vong <[email protected]>
This is one more step of #6323. Note that this also renames/moves a few things to make more sense.
This is one more step of #6323. Note that this also renames/moves a few things to make more sense.
Uh oh!
There was an error while loading. Please reload this page.
There are a few code quality & linting issues in the new replay codebase that we want to fix/align:
no-console
rule #6347no-restricted-globals
- ref(replay): UseWINDOW
instead ofwindow
#6316@typescript-eslint/no-floating-promises
rule #6344naming-convention
EsLint rule #6419@typescript-eslint/explicit-member-accessibility
- ref(replay): Mark all methods & properties as public/private #6734jsdoc/require-jsdoc
- ref(replay): Add jsdoc to all replay modules #6654The text was updated successfully, but these errors were encountered: