Skip to content

[replay] Linting & code quality alignments #6323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
Tracked by #6458
mydea opened this issue Nov 29, 2022 · 3 comments
Closed
6 tasks done
Tracked by #6458

[replay] Linting & code quality alignments #6323

mydea opened this issue Nov 29, 2022 · 3 comments
Assignees
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement

Comments

@mydea
Copy link
Member

mydea commented Nov 29, 2022

There are a few code quality & linting issues in the new replay codebase that we want to fix/align:

@Lms24
Copy link
Member

Lms24 commented Dec 7, 2022

I'm going to remove the @sentry-internal/sdk/no-async-await rule from this list as I just checked and we don't polyfill this anymore when building our CDN bundles or transpiling NPM JS files. Given that Replay doesn't work with IE11 and we only create ES6 bundles, I don't think there's a reason that we'd have to tackle this. cc @mydea

h/t @lobsterkatie for bringing this up.

@mydea
Copy link
Member Author

mydea commented Dec 7, 2022

amazing, this is great!

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

mydea added a commit that referenced this issue Jan 4, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
mydea added a commit that referenced this issue Jan 4, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
mydea added a commit that referenced this issue Jan 4, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
wip


Apply suggestions from code review

Co-authored-by: Billy Vong <[email protected]>
mydea added a commit that referenced this issue Jan 5, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
wip


Apply suggestions from code review

Co-authored-by: Billy Vong <[email protected]>
mydea added a commit that referenced this issue Jan 5, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
wip


Apply suggestions from code review

Co-authored-by: Billy Vong <[email protected]>
mydea added a commit that referenced this issue Jan 5, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
wip


Apply suggestions from code review

Co-authored-by: Billy Vong <[email protected]>
mydea added a commit that referenced this issue Jan 9, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
wip


Apply suggestions from code review

Co-authored-by: Billy Vong <[email protected]>
mydea added a commit that referenced this issue Jan 9, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
mydea added a commit that referenced this issue Jan 9, 2023
This is one more step of #6323.

Note that this also renames/moves a few things to make more sense.
@mydea mydea closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK Type: Improvement
Projects
None yet
Development

No branches or pull requests

2 participants