-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(svelte): Add withSentryConfig
function to wrap User Svelte Configuration
#5936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea286f6
to
be89c72
Compare
7 tasks
AbhiPrasad
reviewed
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tests!
AbhiPrasad
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - feel free to take any decision you want on my code suggestion
AbhiPrasad
reviewed
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
withSentryConfig
wrapper function to our Svelte SDK which can be used to automatically add Sentry-specific svelte configuration options to our users' configuration insvelte.config.js
. Going forward, this function will allow us to add more sentry-specific config items, such as additional preprocessors to the config without having to ask our users to adjust their config stuff every time we introduce changes.We already have a concrete use case for adding another preprocessor to fix #5923 which will be addressed in a follow-up PR.
The change is fully backward-compatible with how we previously instructed users to add the
componentTrackingPreprocessor
explicitly to their set of preprocessors in their config. However, to make it clear thatwithSentryConfig
is the way forward, this PR deprecatescomponentTrackingPreprocessor
and in v8, we'll remove it from our public exports.Additionally, this PR
withSentryConfig
.