test(e2e): Add framework for canary testing #5935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lforst
commented
Oct 13, 2022
| @@ -7,5 +7,13 @@ | |||
| "testName": "Playwright tests", | |||
| "testCommand": "yarn test" | |||
| } | |||
| ], | |||
| "canaryVersions": [ | |||
There was a problem hiding this comment.
Thought about testing previous versions of react here but it was a PITA to get working with react router so I just dropped it
There was a problem hiding this comment.
react router
React is super backwards compatible so I wouldn't worry too much about it.
AbhiPrasad
approved these changes
Oct 13, 2022
.github/CANARY_FAILURE_TEMPLATE.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| title: Canary tests failed | |||
| labels: 'Status: Untriaged' | |||
There was a problem hiding this comment.
Can we add the tests label here as well?
| @@ -7,5 +7,13 @@ | |||
| "testName": "Playwright tests", | |||
| "testCommand": "yarn test" | |||
| } | |||
| ], | |||
| "canaryVersions": [ | |||
There was a problem hiding this comment.
react router
React is super backwards compatible so I wouldn't worry too much about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5934
This PR adds all necessary pieces for us to do canary tests:
versionsandcanaryVersionsfields in E2E test recipes that can provide dependency overrides (to test different verions for packages).canaryVersionstests are run when theCANARY_E2E_TESTis set.