fix(nextjs): Don't assert existence of req and res in data-fetching wrappers
#5866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Oct 3, 2022
| // Generally we can assume that `req` and `res` are always defined on the server: | ||
| // https://nextjs.org/docs/api-reference/data-fetching/get-initial-props#context-object | ||
| // This does not seem to be the case in dev mode. Because we have no clean way of associating the the data fetcher | ||
| // span with eachother when there are no req or res objects, we simply do not trace them at all here. |
There was a problem hiding this comment.
Suggested change
| // span with eachother when there are no req or res objects, we simply do not trace them at all here. | |
| // span with each other when there are no req or res objects, we simply do not trace them at all here. |
There was a problem hiding this comment.
Ditto with the other comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5864
Next.js'
getInitialPropsfunctions generally are passed request and response objects on the server side. This does not seem to hold in development mode where there are cases that they're undefined.This PR simply stops tracing
getInitialPropsfunctions when there are no request or response objects, because we have no clean way of grouping data fetchers under a transaction when there are noreqandresobjects.Disclaimer: I am still not entirely sure if this is the right approach and how the exact behavior for
getInitialPropsandnext devis, but this is a forward fix to quickly unblock users.