chore(build): Remove redundant tsconfig
settings
#5765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes two
tsconfig
settings which don't have any effect given settings elsewhere in the repo:noEmitHelpers
: The TS config docs aren't super clear in saying this explicitly, butnoEmitHelpers
has no effect in the presence ofimportHelpers: true
, because the latter means that no helper implementations will be emitted in any case, instead being imported fromtslib
.Node types: We've had Node types in our repo-level
tsconfig
for a long time, but all packages which need Node types already specify it themselves. Removing it in our top-level tsconfig also has the advantage that it means we won't accidentally use Node types where we shouldn't (like in browser-based and cross-platform packages).