Skip to content

chore(build): Remove redundant tsconfig settings #5765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

lobsterkatie
Copy link
Member

This removes two tsconfig settings which don't have any effect given settings elsewhere in the repo:

  • noEmitHelpers: The TS config docs aren't super clear in saying this explicitly, but noEmitHelpers has no effect in the presence of importHelpers: true, because the latter means that no helper implementations will be emitted in any case, instead being imported from tslib.

  • Node types: We've had Node types in our repo-level tsconfig for a long time, but all packages which need Node types already specify it themselves. Removing it in our top-level tsconfig also has the advantage that it means we won't accidentally use Node types where we shouldn't (like in browser-based and cross-platform packages).

@lobsterkatie lobsterkatie merged commit c072b89 into master Sep 19, 2022
@lobsterkatie lobsterkatie deleted the kmclb-remove-redundant-global-tsconfig-options branch September 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants