draft: Add metadata around transaction name changes #5709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
10 tasks
AbhiPrasad
force-pushed
the
abhi-transaction-name-change
branch
from
5c28e06 to
8c00b71
Compare
jan-auer
reviewed
Sep 8, 2022
packages/types/src/transaction.ts
Outdated
| nameChanges: TransactionNameChange[]; | ||
|
|
||
| /** The total number of propagations that happened */ | ||
| numPropagations: number; |
There was a problem hiding this comment.
This is called propagations on TransactionNameChange, would opt for using the same shorter name here:
Suggested change
| numPropagations: number; | |
| propagations: number; |
packages/types/src/transaction.ts
Outdated
| */ | ||
| export interface TransactionNameChange { | ||
| // new name | ||
| name: string; |
There was a problem hiding this comment.
As discussed offline, we don't require the name for analysis right now. If we drop it, we further prevent the possibility of capturing unintended.
| // new name | ||
| name: string; | ||
| // unix timestamp when the name was changed | ||
| timestamp: number; |
There was a problem hiding this comment.
FTR: The develop spec and Relay protocol definition should use the same type as other timestamps in the protocol, allowing for ISO strings in addition to numbers.
|
Alright - I'm going to split this PR up so we can start reviewing/testing/and merging in components we can ship |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that adds metadata around transaction name changes for #5679. It's mainly being used to get feedback around the data being sent, and the general approach being used.
If folks are fine with this, I'll split this up into smaller PRs with test changes.
The schema looks like this:
In addition to an array of these transaction name changes, we also store the total amount of propagations, which should help understand the relative nature of the propagations.