Skip to content

ref(core): Log warning on NOK transport response #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022

Conversation

lforst
Copy link
Contributor

@lforst lforst commented May 12, 2022

In the old transports we threw a SentryError on NOK responses. This allowed us to simply catch SentryErrors and log those NOK responses.

Because we don't throw in the new transports, we want to make sure people receive logs for those responses to debug eventual issues.

This PR was triggered by: #5064

@lforst lforst force-pushed the lforst-log-transport-noks branch from 57bf9dc to d86e131 Compare May 12, 2022 11:54
@lforst lforst requested a review from AbhiPrasad May 12, 2022 11:54
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.75 KB (-6.91% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.19 KB (-9.95% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.5 KB (-7.24% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.43 KB (-9.56% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.33 KB (-16.84% 🔽)
@sentry/browser - Webpack (minified) 61.44 KB (-24.82% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.35 KB (-16.88% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.81 KB (-10.92% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.41 KB (-6.39% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.96 KB (-6.24% 🔽)

@lforst lforst merged commit 28c09ad into 7.x May 12, 2022
@lforst lforst deleted the lforst-log-transport-noks branch May 12, 2022 12:39
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants