Improved image creation #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`new Image()` creation can trigger a bug into an older version of Chrome. I suggest the 'more compliant' way to create a node into the dom. http://stackoverflow.com/questions/15469763/an-attempt-was-made-to-reference-a-node-in-a-context-where-it-does-not-exist
|
This seems legit. From all of my understanding, I'm not sure But with that said, all sources are saying that For posterity, this is my best finding on this: https://stackoverflow.com/questions/6241716/is-there-a-difference-between-new-image-and-document-createelementimg Thanks! 🍰 ✨ |
|
Crap, this did break tests though. :/ I have no idea why Travis isn't testing pull requests or I would have caught this before merging. |
|
I have edited the file on GitHub, I was not able to do some tests. |
mattrobenolt
added a commit
that referenced
this pull request
Mar 19, 2015
I have no idea how to get sinon to actually stub `document.createElement(‘img’)` and every attempt causes Phantom to stop responding. This was the easiest way out. I’m sorry. This is a test backfilled for #334
|
You still get cake. |
matghaleb
pushed a commit
to matghaleb/raven-js
that referenced
this pull request
Sep 9, 2015
I have no idea how to get sinon to actually stub `document.createElement(‘img’)` and every attempt causes Phantom to stop responding. This was the easiest way out. I’m sorry. This is a test backfilled for getsentry#334
kamilogorek
pushed a commit
that referenced
this pull request
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Image()creation can trigger a bug into an older version of Chrome.I suggest the 'more compliant' way to create a node into the dom.
http://stackoverflow.com/questions/15469763/an-attempt-was-made-to-reference-a-node-in-a-context-where-it-does-not-exist