Cover both reported Chrome anonymous function stacktrace lines #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted cases of anonymous functions
juriejan
changed the title
| gecko = /^\s*(.*?)(?:\((.*?)\))?@((?:file|https?|chrome).*?):(\d+)(?::(\d+))?\s*$/i, | ||
| lines = ex.stack.split('\n'), | ||
| stack = [], | ||
| parts, | ||
| element, | ||
| func, |
There was a problem hiding this comment.
Not sure why you added this.
|
Thought I was missing something obvious. Fixed as per comments. |
| @@ -651,7 +651,7 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() { | |||
| } else if ((parts = chrome.exec(lines[i]))) { | |||
| element = { | |||
| 'url': parts[2], | |||
| 'func': parts[1] || UNKNOWN_FUNCTION, | |||
| 'func': (parts[1] || UNKNOWN_FUNCTION), | |||
There was a problem hiding this comment.
These added parens are now unnecessary too.
Everything else looks good. :)
|
Awesome. Thanks! 🍰 ✨ |
mattrobenolt
added a commit
that referenced
this pull request
Nov 26, 2014
Cover both reported Chrome anonymous function stacktrace lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #290 broke the fix in #238. This PR covers both cases. Not sure if it's the most elegant solution, but it's the best I could do within a limited time frame.