Skip to content

Conversation

kamilogorek
Copy link
Contributor

No description provided.

@kamilogorek kamilogorek requested a review from HazAT November 21, 2019 15:59
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Nov 21, 2019

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 ✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: (ES6: 15.4219 kB) (ES5: 16.3281 kB)

Generated by 🚫 dangerJS against 1721330

@HazAT HazAT marked this pull request as ready for review November 25, 2019 13:50
function instrument(type: InstrumentHandlerType): void {
if (type === 'console') {
instrumentConsole();
instrumented[type] = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to go outside the if + we need a check each if if already patched.

@kamilogorek kamilogorek force-pushed the instrumentation-refactor branch from 72a6ed9 to 4dd643c Compare November 26, 2019 15:50
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@kamilogorek kamilogorek force-pushed the instrumentation-refactor branch from 4dd643c to 1721330 Compare November 26, 2019 19:13
@HazAT HazAT merged commit 4905a84 into master Nov 27, 2019
@HazAT HazAT deleted the instrumentation-refactor branch November 27, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants