chore(react): Inline hoist-non-react-statics package
#18102
+472
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/inline-hoist-non-react-statics
branch
from
b28862f to
4cfaf34
Compare
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
onurtemizkan
force-pushed
the
onur/inline-hoist-non-react-statics
branch
3 times, most recently
from
76f668a to
8d0a14e
Compare
chargome
approved these changes
Nov 17, 2025
onurtemizkan
force-pushed
the
onur/inline-hoist-non-react-statics
branch
from
3e95001 to
09dd869
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
packages/react/package.json
Outdated
Comment on lines
42
to
45
| "@sentry/browser": "10.25.0", | ||
| "@sentry/core": "10.25.0" | ||
| "@sentry/browser": "10.30.0", | ||
| "@sentry/core": "10.30.0", |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
onurtemizkan
force-pushed
the
onur/inline-hoist-non-react-statics
branch
from
2b9939c to
1223695
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "@types/history-4": "npm:@types/[email protected]", | ||
| "@types/history-5": "npm:@types/[email protected]", | ||
| "@types/hoist-non-react-statics": "^3.3.5", | ||
| "@types/node-fetch": "^2.6.11", |
There was a problem hiding this comment.
Bug: Unrelated @types/node-fetch dependency accidentally added
The @types/node-fetch package was added to devDependencies where @types/hoist-non-react-statics was removed. There's no usage of node-fetch anywhere in the react package, so this appears to be accidentally included during the edit. The dependency is unused and adds unnecessary bloat to the dev dependencies.
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref / Resolves: #18089
hoist-non-react-staticspackage we depend on is not ESM compatible, and causing issues for users on Cloudflare environments. As this package has not been updated in 5 years, and our use has not changed for long time, I think we can just inline this to make it compatible, and save users from explicitly externalizing this package.