-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(firebase): Instrument cloud functions for firebase v2 #17952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c85adc to
ea06541
Compare
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JPeer264 did you figure out what to do about flushing yet? Will that be part of this PR?
dev-packages/e2e-tests/test-applications/node-firebase/firestore-app/package.json
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-firebase/functions/package.json
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-firebase/firestore-app/package.json
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-firebase/functions/package.json
Outdated
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-firebase/tests/functions.test.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-firebase/tests/functions.test.ts
Show resolved
Hide resolved
packages/node/src/integrations/tracing/firebase/otel/patches/functions.ts
Outdated
Show resolved
Hide resolved
packages/node/src/integrations/tracing/firebase/otel/patches/functions.ts
Outdated
Show resolved
Hide resolved
|
A short update. After the first review I changed three major things:
|
a28cf51 to
bc71a98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
…ith otel standards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to bump the size limit of @sentry/node inside .size-limit.js then good to go!
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR This adds the documentation for Firebase integrations added in getsentry/sentry-javascript#17952 and getsentry/sentry-javascript#16719 closes #15247 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Closes: #17861
This adds
Sentry.firebaseIntegration()(this is atm not documented in the docs and got added in feat(node): Add firebase integration #16719, but will be added right after this has been merged. See Add Firebase integration in the docs sentry-docs#15247).Supported functions
Bear in mind that the OTel attributes for FaaS are still in Development and could change or be removed over time (not sure if we should then even add them in here at this point in time).