-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Expose AI instrumentation methods #17848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RulaKhaled
merged 13 commits into
develop
from
rolaabuhasna/js-945-expose-ai-integrations-in-browser-sdk
Oct 14, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
db55a48
feat(browser): Expose AI instrumentation methods
RulaKhaled a8e10f4
Fix linter
RulaKhaled d611a75
update with init
RulaKhaled f2d429c
await the call
RulaKhaled affb6f9
try to fix timeout issue
RulaKhaled 62397c5
one more try
RulaKhaled 535e8dc
debug
RulaKhaled d050046
debug
RulaKhaled 43c45d2
cdn the instrumentations
RulaKhaled 78adfa8
update with rollup bundle path
RulaKhaled f79f878
thank you lukas
RulaKhaled b4dabc2
bump bundle size for broswer
RulaKhaled fe92b1e
linter yellin
RulaKhaled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
dev-packages/browser-integration-tests/suites/tracing/ai-providers/anthropic/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as Sentry from '@sentry/browser'; | ||
|
|
||
| window.Sentry = Sentry; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://[email protected]/1337', | ||
| tracesSampleRate: 1, | ||
| debug: true, | ||
| }); |
55 changes: 55 additions & 0 deletions
55
dev-packages/browser-integration-tests/suites/tracing/ai-providers/anthropic/mocks.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Mock Anthropic client for browser testing | ||
| export class MockAnthropic { | ||
| constructor(config) { | ||
| this.apiKey = config.apiKey; | ||
|
|
||
| // Main focus: messages.create functionality | ||
| this.messages = { | ||
| create: async (...args) => { | ||
| const params = args[0]; | ||
| // Simulate processing time | ||
| await new Promise(resolve => setTimeout(resolve, 10)); | ||
|
|
||
| if (params.model === 'error-model') { | ||
| const error = new Error('Model not found'); | ||
| error.status = 404; | ||
| error.headers = { 'x-request-id': 'mock-request-123' }; | ||
| throw error; | ||
| } | ||
|
|
||
| const response = { | ||
| id: 'msg_mock123', | ||
| type: 'message', | ||
| role: 'assistant', | ||
| model: params.model, | ||
| content: [ | ||
| { | ||
| type: 'text', | ||
| text: 'Hello from Anthropic mock!', | ||
| }, | ||
| ], | ||
| stop_reason: 'end_turn', | ||
| stop_sequence: null, | ||
| usage: { | ||
| input_tokens: 10, | ||
| output_tokens: 15, | ||
| cache_creation_input_tokens: 0, | ||
| cache_read_input_tokens: 0, | ||
| }, | ||
| }; | ||
| return response; | ||
| }, | ||
| countTokens: async (..._args) => ({ id: 'mock', type: 'model', model: 'mock', input_tokens: 0 }), | ||
| }; | ||
|
|
||
| // Minimal implementations for required interface compliance | ||
| this.models = { | ||
| list: async (..._args) => ({ id: 'mock', type: 'model', model: 'mock' }), | ||
| get: async (..._args) => ({ id: 'mock', type: 'model', model: 'mock' }), | ||
| }; | ||
|
|
||
| this.completions = { | ||
| create: async (..._args) => ({ id: 'mock', type: 'completion', model: 'mock' }), | ||
| }; | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
dev-packages/browser-integration-tests/suites/tracing/ai-providers/anthropic/subject.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { instrumentAnthropicAiClient } from '@sentry/browser'; | ||
| import { MockAnthropic } from './mocks.js'; | ||
|
|
||
| const mockClient = new MockAnthropic({ | ||
| apiKey: 'mock-api-key', | ||
| }); | ||
|
|
||
| const client = instrumentAnthropicAiClient(mockClient); | ||
|
|
||
| // Test that manual instrumentation doesn't crash the browser | ||
| // The instrumentation automatically creates spans | ||
| const response = await client.messages.create({ | ||
| model: 'claude-3-haiku-20240307', | ||
| messages: [{ role: 'user', content: 'What is the capital of France?' }], | ||
| temperature: 0.7, | ||
| max_tokens: 100, | ||
| }); | ||
|
|
||
| console.log('Received response', response); | ||
36 changes: 36 additions & 0 deletions
36
dev-packages/browser-integration-tests/suites/tracing/ai-providers/anthropic/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { expect } from '@playwright/test'; | ||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { envelopeRequestParser, waitForTransactionRequest } from '../../../../utils/helpers'; | ||
|
|
||
| // These tests are not exhaustive because the instrumentation is | ||
| // already tested in the node integration tests and we merely | ||
| // want to test that the instrumentation does not crash in the browser | ||
| // and that gen_ai transactions are sent. | ||
|
|
||
| sentryTest('manual Anthropic instrumentation sends gen_ai transactions', async ({ getLocalTestUrl, page }) => { | ||
| const transactionPromise = waitForTransactionRequest(page, event => { | ||
| return !!event.transaction?.includes('claude-3-haiku-20240307'); | ||
| }); | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| await page.goto(url); | ||
|
|
||
| const req = await transactionPromise; | ||
|
|
||
| const eventData = envelopeRequestParser(req); | ||
|
|
||
| // Verify it's a gen_ai transaction | ||
| expect(eventData.transaction).toBe('messages claude-3-haiku-20240307'); | ||
| expect(eventData.contexts?.trace?.op).toBe('gen_ai.messages'); | ||
| expect(eventData.contexts?.trace?.origin).toBe('auto.ai.anthropic'); | ||
| expect(eventData.contexts?.trace?.data).toMatchObject({ | ||
| 'gen_ai.operation.name': 'messages', | ||
| 'gen_ai.system': 'anthropic', | ||
| 'gen_ai.request.model': 'claude-3-haiku-20240307', | ||
| 'gen_ai.request.temperature': 0.7, | ||
| 'gen_ai.response.model': 'claude-3-haiku-20240307', | ||
| 'gen_ai.response.id': 'msg_mock123', | ||
| 'gen_ai.usage.input_tokens': 10, | ||
| 'gen_ai.usage.output_tokens': 15, | ||
| }); | ||
| }); |
9 changes: 9 additions & 0 deletions
9
dev-packages/browser-integration-tests/suites/tracing/ai-providers/google-genai/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as Sentry from '@sentry/browser'; | ||
|
|
||
| window.Sentry = Sentry; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://[email protected]/1337', | ||
| tracesSampleRate: 1, | ||
| debug: true, | ||
| }); |
118 changes: 118 additions & 0 deletions
118
dev-packages/browser-integration-tests/suites/tracing/ai-providers/google-genai/mocks.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| // Mock Google GenAI client for browser testing | ||
| export class MockGoogleGenAI { | ||
| constructor(config) { | ||
| this.apiKey = config.apiKey; | ||
|
|
||
| // models.generateContent functionality | ||
| this.models = { | ||
| generateContent: async (...args) => { | ||
| const params = args[0]; | ||
| // Simulate processing time | ||
| await new Promise(resolve => setTimeout(resolve, 10)); | ||
|
|
||
| if (params.model === 'error-model') { | ||
| const error = new Error('Model not found'); | ||
| error.status = 404; | ||
| error.headers = { 'x-request-id': 'mock-request-123' }; | ||
| throw error; | ||
| } | ||
|
|
||
| return { | ||
| candidates: [ | ||
| { | ||
| content: { | ||
| parts: [ | ||
| { | ||
| text: 'Hello from Google GenAI mock!', | ||
| }, | ||
| ], | ||
| role: 'model', | ||
| }, | ||
| finishReason: 'stop', | ||
| index: 0, | ||
| }, | ||
| ], | ||
| usageMetadata: { | ||
| promptTokenCount: 8, | ||
| candidatesTokenCount: 12, | ||
| totalTokenCount: 20, | ||
| }, | ||
| }; | ||
| }, | ||
| generateContentStream: async () => { | ||
| // Return a promise that resolves to an async generator | ||
| return (async function* () { | ||
| yield { | ||
| candidates: [ | ||
| { | ||
| content: { | ||
| parts: [{ text: 'Streaming response' }], | ||
| role: 'model', | ||
| }, | ||
| finishReason: 'stop', | ||
| index: 0, | ||
| }, | ||
| ], | ||
| }; | ||
| })(); | ||
| }, | ||
| }; | ||
|
|
||
| // chats.create implementation | ||
| this.chats = { | ||
| create: (...args) => { | ||
| const params = args[0]; | ||
| const model = params.model; | ||
|
|
||
| return { | ||
| modelVersion: model, | ||
| sendMessage: async (..._messageArgs) => { | ||
| // Simulate processing time | ||
| await new Promise(resolve => setTimeout(resolve, 10)); | ||
|
|
||
| const response = { | ||
| candidates: [ | ||
| { | ||
| content: { | ||
| parts: [ | ||
| { | ||
| text: 'This is a joke from the chat!', | ||
| }, | ||
| ], | ||
| role: 'model', | ||
| }, | ||
| finishReason: 'stop', | ||
| index: 0, | ||
| }, | ||
| ], | ||
| usageMetadata: { | ||
| promptTokenCount: 8, | ||
| candidatesTokenCount: 12, | ||
| totalTokenCount: 20, | ||
| }, | ||
| modelVersion: model, // Include model version in response | ||
| }; | ||
| return response; | ||
| }, | ||
| sendMessageStream: async () => { | ||
| // Return a promise that resolves to an async generator | ||
| return (async function* () { | ||
| yield { | ||
| candidates: [ | ||
| { | ||
| content: { | ||
| parts: [{ text: 'Streaming chat response' }], | ||
| role: 'model', | ||
| }, | ||
| finishReason: 'stop', | ||
| index: 0, | ||
| }, | ||
| ], | ||
| }; | ||
| })(); | ||
| }, | ||
| }; | ||
| }, | ||
| }; | ||
| } | ||
| } |
32 changes: 32 additions & 0 deletions
32
dev-packages/browser-integration-tests/suites/tracing/ai-providers/google-genai/subject.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { instrumentGoogleGenAIClient } from '@sentry/browser'; | ||
| import { MockGoogleGenAI } from './mocks.js'; | ||
|
|
||
| const mockClient = new MockGoogleGenAI({ | ||
| apiKey: 'mock-api-key', | ||
| }); | ||
|
|
||
| const client = instrumentGoogleGenAIClient(mockClient); | ||
|
|
||
| // Test that manual instrumentation doesn't crash the browser | ||
| // The instrumentation automatically creates spans | ||
| // Test both chats and models APIs | ||
| const chat = client.chats.create({ | ||
| model: 'gemini-1.5-pro', | ||
| config: { | ||
| temperature: 0.8, | ||
| topP: 0.9, | ||
| maxOutputTokens: 150, | ||
| }, | ||
| history: [ | ||
| { | ||
| role: 'user', | ||
| parts: [{ text: 'Hello, how are you?' }], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| const response = await chat.sendMessage({ | ||
| message: 'Tell me a joke', | ||
| }); | ||
|
|
||
| console.log('Received response', response); |
31 changes: 31 additions & 0 deletions
31
dev-packages/browser-integration-tests/suites/tracing/ai-providers/google-genai/test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { expect } from '@playwright/test'; | ||
| import { sentryTest } from '../../../../utils/fixtures'; | ||
| import { envelopeRequestParser, waitForTransactionRequest } from '../../../../utils/helpers'; | ||
|
|
||
| // These tests are not exhaustive because the instrumentation is | ||
| // already tested in the node integration tests and we merely | ||
| // want to test that the instrumentation does not crash in the browser | ||
| // and that gen_ai transactions are sent. | ||
|
|
||
| sentryTest('manual Google GenAI instrumentation sends gen_ai transactions', async ({ getLocalTestUrl, page }) => { | ||
| const transactionPromise = waitForTransactionRequest(page, event => { | ||
| return !!event.transaction?.includes('gemini-1.5-pro'); | ||
| }); | ||
|
|
||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| await page.goto(url); | ||
|
|
||
| const req = await transactionPromise; | ||
|
|
||
| const eventData = envelopeRequestParser(req); | ||
|
|
||
| // Verify it's a gen_ai transaction | ||
| expect(eventData.transaction).toBe('chat gemini-1.5-pro create'); | ||
| expect(eventData.contexts?.trace?.op).toBe('gen_ai.chat'); | ||
| expect(eventData.contexts?.trace?.origin).toBe('auto.ai.google_genai'); | ||
| expect(eventData.contexts?.trace?.data).toMatchObject({ | ||
| 'gen_ai.operation.name': 'chat', | ||
| 'gen_ai.system': 'google_genai', | ||
| 'gen_ai.request.model': 'gemini-1.5-pro', | ||
| }); | ||
| }); |
9 changes: 9 additions & 0 deletions
9
dev-packages/browser-integration-tests/suites/tracing/ai-providers/openai/init.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import * as Sentry from '@sentry/browser'; | ||
|
|
||
| window.Sentry = Sentry; | ||
|
|
||
| Sentry.init({ | ||
| dsn: 'https://[email protected]/1337', | ||
| tracesSampleRate: 1, | ||
| debug: true, | ||
| }); |
47 changes: 47 additions & 0 deletions
47
dev-packages/browser-integration-tests/suites/tracing/ai-providers/openai/mocks.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // Mock OpenAI client for browser testing | ||
| export class MockOpenAi { | ||
| constructor(config) { | ||
| this.apiKey = config.apiKey; | ||
|
|
||
| this.chat = { | ||
| completions: { | ||
| create: async (...args) => { | ||
| const params = args[0]; | ||
| // Simulate processing time | ||
| await new Promise(resolve => setTimeout(resolve, 10)); | ||
|
|
||
| if (params.model === 'error-model') { | ||
| const error = new Error('Model not found'); | ||
| error.status = 404; | ||
| error.headers = { 'x-request-id': 'mock-request-123' }; | ||
| throw error; | ||
| } | ||
|
|
||
| const response = { | ||
| id: 'chatcmpl-mock123', | ||
| object: 'chat.completion', | ||
| created: 1677652288, | ||
| model: params.model, | ||
| system_fingerprint: 'fp_44709d6fcb', | ||
| choices: [ | ||
| { | ||
| index: 0, | ||
| message: { | ||
| role: 'assistant', | ||
| content: 'Hello from OpenAI mock!', | ||
| }, | ||
| finish_reason: 'stop', | ||
| }, | ||
| ], | ||
| usage: { | ||
| prompt_tokens: 10, | ||
| completion_tokens: 15, | ||
| total_tokens: 25, | ||
| }, | ||
| }; | ||
| return response; | ||
| }, | ||
| }, | ||
| }; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: It isn't ideal for an integration test to mock the client we want to instrument. In our Node integration tests we usually test against the actual libraries (though not sure about AI packages to be fair).
I'm not sure if this works out of the box but we can try adding the packages as dependencies to the browser-integration-tests package.json and then just importing them in the subject files. We bundle each individual integration test suite via webpack so maybe webpack can actually resolve and bundle the dependencies out of the box. If this doesn't work, we should find a way to make this possible. I'm sure this is also a concern for logging libraries used in browser apps.
I'm fine though with merging the PR as-is and following up with replacing the mocks with the actual test apps. Whatever works for you better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mock the server apis for AI tests usually, yep can do in a follow up, will draft a ticket for this.