-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay/logs): Only attach sampled replay Ids to logs #17750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
If replay is not sampled, should there not be no session ID at all, as we should not record...? |
I think the Id is always created, regardless of the sampling decision |
Adds an option to
getSessionId
andgetSessionId
to only return a value if the replay is sampled.ref #17676