ci(test-matrix): Add logs for getTestMatrix
#17673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
mydea
reviewed
Sep 17, 2025
| // eslint-disable-next-line no-console | ||
| console.error( | ||
| `Discovered ${testApplications.length} test applications${ | ||
| testApplications.length > 0 |
There was a problem hiding this comment.
let's just make this testApplications.join(', ')? Doesn't really matter if this list is long I suppose 😅
mydea
reviewed
Sep 17, 2025
| .filter(Boolean); | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('Failed to compute affected projects via Nx. Running all tests instead.', error); |
There was a problem hiding this comment.
Suggested change
| console.warn('Failed to compute affected projects via Nx. Running all tests instead.', error); | |
| console.error('Failed to compute affected projects via Nx. Running all tests instead.', error); |
here an error is def. warranted xD
mydea
approved these changes
Sep 17, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some test for generating the test matrix to be able to easily debug it.