Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 16, 2025

#17653 failed in CI because of a non-breaking plugin option change in 4.3.0. Because we use both Vite and Rollup plugins in Nuxt, the combined getPluginOptions function would throw a type error if the respective option types differed.

This PR bumps both dependencies at once which should fix the type error.

Copy link
Contributor

github-actions bot commented Sep 16, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,974 - 8,911 +1%
GET With Sentry 1,408 16% 1,422 -1%
GET With Sentry (error only) 6,001 67% 6,012 -0%
POST Baseline 1,211 - 1,180 +3%
POST With Sentry 528 44% 504 +5%
POST With Sentry (error only) 1,086 90% 1,045 +4%
MYSQL Baseline 3,334 - 3,335 -0%
MYSQL With Sentry 530 16% 463 +14%
MYSQL With Sentry (error only) 2,720 82% 2,702 +1%

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants