fix(node): Preserve synchronous return behavior for streamText and other methods for AI #17580
Conversation
…her methods for AI
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
size-limit report 📦
|
| checkResultForToolErrors(result); | ||
| if (isPromiseLike(result)) { | ||
| // check for tool errors when the promise resolves, keep the original promise identity | ||
| result.then(checkResultForToolErrors, () => {}); |
There was a problem hiding this comment.
hmm, I think we need to re-throw here or something like this, as otherwise this could swallow unhandled promise rejections, possibly...? Can this be? This is always hard tor reason about for me...
There was a problem hiding this comment.
oh yah it confuses me too! I just tested this though and the error should bubble up to user as expected
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| * @param value The value to check. | ||
| * @returns True if the value is a promise like object, false otherwise. | ||
| */ | ||
| function isPromiseLike<T = unknown>(value: unknown): value is PromiseLike<T> { |
There was a problem hiding this comment.
instead of this, you could also use the existing isThenable utility!
Vercel AI integration was incorrectly wrapping all patched methods in an async function, causing synchronous methods like streamText to return Promises when they should return synchronous objects.
Resolves: #17553