ref(nextjs): Set more specific event mechanisms
#17543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/ref-nextjs-mechanism
branch
from
4b4059e to
8c80a53
Compare
Lms24
requested review from
chargome and
RulaKhaled
and removed request for
chargome
Lms24
force-pushed
the
lms/ref-nextjs-mechanism
branch
from
8c80a53 to
50924ca
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
RulaKhaled
approved these changes
Sep 12, 2025
| test.skip(process.env.TEST_ENV === 'development', 'test is flakey in dev mode'); | ||
|
|
||
| const sessionPromise = waitForSession('nextjs-13', session => { | ||
| console.log('session', session); |
There was a problem hiding this comment.
yah can we get rid of this please
Lms24
commented
Sep 12, 2025
dev-packages/e2e-tests/test-applications/nextjs-13/tests/client/sessions.test.ts
Outdated
Show resolved
Hide resolved
…t/sessions.test.ts
Lms24
force-pushed
the
lms/ref-nextjs-mechanism
branch
from
e71da78 to
f5ae12f
Compare
This was referenced Sep 23, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exception mechanism now follows the trace origin naming scheme.
Also added a couple of test assertions for tests expecting errors.
closes #17258