feat(deno): Add OpenTelemetry support and vercelAI integration #17445
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for the PR Sergiy! Just for me to understand this better: doesn't Deno come with a built-in otel tracer already? |
From chatting with @AbhiPrasad, we can't use it due to the limitations
|
| * The only difference is that it does not use `@opentelemetry/instrumentation` | ||
| * because Deno Workers do not support it in the same way. | ||
| * | ||
| * Therefore, we cannot automatically patch setting `experimental_telemetry: { isEnabled: true }` | ||
| * and users have to manually set this to get spans. |
There was a problem hiding this comment.
I think this comment is wrong, I would just remove it - this is just a 1-1 copy of the cloudflare one, right? :D
So either we just say "this is a copt of the cloudflare one" or we copy the whole comment and say "it is a copy of the node one, but...."
There was a problem hiding this comment.
removed the comment, just left as copy from cloudflare
There was a problem hiding this comment.
generally this looks good to me - just to double check, does this conflict in any way with deno native otel support? We should make sure to test this that everything works as expected for both ends, so native otel stuff continues to work and our stuff continues to work if that is used 🤔
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@mydea added tests for providers co-existing and not overriding each other, haven't tested end to end with actual OTeL instrumentation locally, lmk if this is enough or I should dig deeper |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Based on the Cloudflare OTel implementation