-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(solidjs): Add sourcemap instructions to README #12425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend we use the debugId-based source maps upload instructions: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/
We should probably update this in the Svelte instructions as well but let's start here.
With "using the wizard", you mean adding a path to the -i sourcemaps
wizard? Or setting up the entire SDK, including sourcemaps, with the wizard?
with using the wizard I meant |
Another question: Have you tried using the Vite plugin? Is there a reason we should recommend the CLI over the plugin? |
yes, I tried both the vite plugin and the CLI. I'm also leaning towards just recommending the vite plugin because it's so much simpler. |
@Lms24 I removed the section on CLI and just link to the source map guide in the docs. lmk if you think we should add more. |
e2791fa
to
2fc0eea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think thats a good idea. Less duplication.
I pretty much copied these instructions from the svelte sdk. They work, although the wizard does not detect the sdk yet.
That being said, I was thinking of recommending using the wizard over creating a bash script, wdyat?
It works:
