Skip to content

Conversation

andreiborza
Copy link
Member

@andreiborza andreiborza commented Jun 10, 2024

I pretty much copied these instructions from the svelte sdk. They work, although the wizard does not detect the sdk yet.
That being said, I was thinking of recommending using the wizard over creating a bash script, wdyat?

It works:
sourcemap

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend we use the debugId-based source maps upload instructions: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/

We should probably update this in the Svelte instructions as well but let's start here.

With "using the wizard", you mean adding a path to the -i sourcemaps wizard? Or setting up the entire SDK, including sourcemaps, with the wizard?

@andreiborza andreiborza added the Package: solid Issues related to the Sentry Solid SDK label Jun 10, 2024
@andreiborza
Copy link
Member Author

I'd recommend we use the debugId-based source maps upload instructions: https://docs.sentry.io/platforms/javascript/sourcemaps/uploading/cli/

We should probably update this in the Svelte instructions as well but let's start here.

With "using the wizard", you mean adding a path to the -i sourcemaps wizard? Or setting up the entire SDK, including sourcemaps, with the wizard?

with using the wizard I meant npx @sentry/wizard@latest -i sourcemaps yep.

@Lms24
Copy link
Member

Lms24 commented Jun 10, 2024

Another question: Have you tried using the Vite plugin? Is there a reason we should recommend the CLI over the plugin?

@andreiborza
Copy link
Member Author

Another question: Have you tried using the Vite plugin? Is there a reason we should recommend the CLI over the plugin?

yes, I tried both the vite plugin and the CLI. I'm also leaning towards just recommending the vite plugin because it's so much simpler.

@andreiborza andreiborza requested a review from Lms24 June 10, 2024 09:06
@andreiborza
Copy link
Member Author

@Lms24 I removed the section on CLI and just link to the source map guide in the docs. lmk if you think we should add more.

@andreiborza andreiborza force-pushed the ab/solidjs-readme-sourcemap branch from e2791fa to 2fc0eea Compare June 10, 2024 09:15
@andreiborza andreiborza merged commit 30f0c55 into develop Jun 10, 2024
@andreiborza andreiborza deleted the ab/solidjs-readme-sourcemap branch June 10, 2024 09:34
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think thats a good idea. Less duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: solid Issues related to the Sentry Solid SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants