Skip to content

Conversation

AbhiPrasad
Copy link
Member

resolves #12242 (although there are still some follow ups)

https://github.com/open-telemetry/opentelemetry-js/releases/tag/v1.25.0

I think this lockfile looks correct, but lmk if this feels off.

resolves #12011
resolves #12059
resolves #12154
resolves #12237
resolves nodejs/import-in-the-middle#77 cc @mohd-akram

@AbhiPrasad AbhiPrasad requested review from timfish, a team, lforst and Lms24 and removed request for a team June 6, 2024 13:35
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lforst
Copy link
Contributor

lforst commented Jun 6, 2024

big

@AbhiPrasad
Copy link
Member Author

woops forgot they were allowed to make breaking changes in some packages 😬

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) June 6, 2024 14:09
Copy link
Contributor

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size
@sentry/browser 22 KB (0%)
@sentry/browser (incl. Tracing) 33.05 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) 68.65 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.94 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.7 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.82 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.66 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.18 KB (0%)
@sentry/browser (incl. Feedback) 38.16 KB (0%)
@sentry/browser (incl. sendFeedback) 26.59 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.14 KB (0%)
@sentry/react 24.77 KB (0%)
@sentry/react (incl. Tracing) 36.08 KB (+0.01% 🔺)
@sentry/vue 26 KB (0%)
@sentry/vue (incl. Tracing) 34.87 KB (+0.01% 🔺)
@sentry/svelte 22.13 KB (0%)
CDN Bundle 23.35 KB (0%)
CDN Bundle (incl. Tracing) 34.73 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) 68.67 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.83 KB (+0.01% 🔺)
CDN Bundle - uncompressed 68.6 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 102.8 KB (+0.03% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212.73 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 225.2 KB (+0.01% 🔺)
@sentry/nextjs (client) 35.45 KB (+0.01% 🔺)
@sentry/sveltekit (client) 33.68 KB (+0.01% 🔺)
@sentry/node 129.96 KB (+12.2% 🔺)
@sentry/node - without tracing 92.7 KB (-2.33% 🔽)
@sentry/aws-serverless 117.75 KB (+13.1% 🔺)

@AbhiPrasad
Copy link
Member Author

Note: The OTEL bump seems to have increased the min memory usage of the SDK, something worthwhile to dive into.

@AbhiPrasad AbhiPrasad merged commit a16b557 into develop Jun 6, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-otel branch June 6, 2024 15:47
billyvg pushed a commit that referenced this pull request Jun 10, 2024
resolves #12242
(although there are still some follow ups)

https://github.com/open-telemetry/opentelemetry-js/releases/tag/v1.25.0

I think this lockfile looks correct, but lmk if this feels off.

resolves #12011
resolves #12059
resolves #12154
resolves #12237
resolves nodejs/import-in-the-middle#77 cc
@mohd-akram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants