Skip to content

test: Fix test for release branch #11612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

test: Fix test for release branch #11612

merged 1 commit into from
Apr 15, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 15, 2024

Sadly, our release failed. The reason is that the lazy load integration test loads the CDN bundle with the current version, which obv. does not exist yet 😬 so we now properly mock this so this always passes.

@mydea mydea requested review from lforst, Lms24 and AbhiPrasad April 15, 2024 15:08
@mydea mydea self-assigned this Apr 15, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this only happens now 🤔 but great catch!

@mydea mydea merged commit ac81016 into develop Apr 15, 2024
@mydea mydea deleted the fn/fix-publish-test branch April 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants