feat(node): Send ANR events from main thread #11525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
timfish
changed the title
|
If the event loop is blocked indefinitely, #11578 fixes where we're waiting on the scope to be returned in the existing implementation. |
AbhiPrasad
pushed a commit
that referenced
this pull request
Apr 12, 2024
…nitely (#11578) When experimenting for #11525 I found that `Runtime.evaluate` only returns when the event loop becomes unblocked. This means that we are not sending ANR events if the event loop is blocked indefinitely. This PR adds a timeout that sends the ANR event if we have not been able to evaluate the scope within 5 seconds.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…nitely (getsentry#11578) When experimenting for getsentry#11525 I found that `Runtime.evaluate` only returns when the event loop becomes unblocked. This means that we are not sending ANR events if the event loop is blocked indefinitely. This PR adds a timeout that sends the ANR event if we have not been able to evaluate the scope within 5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the ANR integration to send ANR events from the main thread via the debugger interface.
Negatives
captureStackTraceoption is removed as it's we require the debugger to send the events to the main thread. ANR without stack traces are not very actionable anyway [BREAKING!]Positives
beforeSendnow workStill TODO