Skip to content

build: Reorganize size limit and restructure limits #11454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Apr 5, 2024

Next week I'm going to play around with optimizing feedback/replay packages as per what we saw in #11452.

In prep for that work I re-organized size limit and made the limits a little more sensible.

The size bot comment will be a little messed up because we renamed the fields, but after we merge should be a lot better.

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and s1gr1d and removed request for a team April 5, 2024 21:07
@AbhiPrasad AbhiPrasad self-assigned this Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 75.73 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) 66.96 KB (+0.15% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.8 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.58 KB (+0.24% 🔺)
@sentry/browser (incl. Tracing) 31.75 KB (0%)
@sentry/browser (incl. browserTracingIntegration) 0 B (removed)
@sentry/browser (incl. feedbackIntegration) 0 B (removed)
@sentry/browser (incl. feedbackModalIntegration) 0 B (removed)
@sentry/browser (incl. feedbackScreenshotIntegration) 0 B (removed)
@sentry/browser (incl. sendFeedback) 26.89 KB (0%)
@sentry/browser 22.1 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.62 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.37 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) 32.7 KB (-0.02% 🔽)
CDN Bundle 24.13 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 206.99 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.59 KB (0%)
CDN Bundle - uncompressed 71.37 KB (0%)
@sentry/react (incl. Tracing, Replay) 0 B (removed)
@sentry/react 24.78 KB (+12.02% 🔺)
@sentry/browser (incl. Feedback) 30.88 KB (added)
@sentry/browser (incl. Feedback, Feedback Modal) 30.9 KB (added)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 30.9 KB (added)
@sentry/react (incl. Tracing) 34.65 KB (added)
@sentry/vue 25.59 KB (added)
@sentry/vue (incl. Tracing) 33.48 KB (added)
@sentry/svelte 22.23 KB (added)
@sentry/nextjs (client) 33.85 KB (added)
@sentry/sveltekit (client) 32.29 KB (added)
@sentry/node 119.97 KB (added)

@AbhiPrasad
Copy link
Member Author

image

If I set preserveModule: true, there's around 10kb that doesn't get treeshaken in @sentry/node. Not end of the world, but does suck for serverless.

@AbhiPrasad AbhiPrasad merged commit 0ad046a into develop Apr 8, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-reorg-size-limit branch April 8, 2024 13:26
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Next week I'm going to play around with optimizing feedback/replay
packages as per what we saw in
getsentry#11452.

In prep for that work I re-organized size limit and made the limits a
little more sensible.

The size bot comment will be a little messed up because we renamed the
fields, but after we merge should be a lot better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants