ref: Set preserveModules to true for browser packages #11452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
damn lol |
AbhiPrasad
requested review from
a team,
mydea and
lforst
and removed request for
a team
timfish
approved these changes
Apr 5, 2024
|
should I do this for node/replay/feedback as well then? |
|
This was more important for cjs server code anyhow. Id also do it for all of the other browser pkgs! 👍🏼 |
Yeah, probably a good idea! If anything there are more side effects in the Node SDK. |
AbhiPrasad
added a commit
that referenced
this pull request
Apr 8, 2024
Next week I'm going to play around with optimizing feedback/replay packages as per what we saw in #11452. In prep for that work I re-organized size limit and made the limits a little more sensible. The size bot comment will be a little messed up because we renamed the fields, but after we merge should be a lot better.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Next week I'm going to play around with optimizing feedback/replay packages as per what we saw in getsentry#11452. In prep for that work I re-organized size limit and made the limits a little more sensible. The size bot comment will be a little messed up because we renamed the fields, but after we merge should be a lot better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see how much this helps with bundle size.