ref(v8): Remove metadata on transaction
#11397
Conversation
size-limit report 📦
|
packages/core/src/tracing/trace.ts
Outdated
| // TODO: We should probably only set this if we know we are continuing a trace | ||
| // For now, there isn't really a way to know this from in here, though... |
There was a problem hiding this comment.
with "this" are you referring to spanContext? Or should this be moved to the if(dsc) part below?
There was a problem hiding this comment.
ah wait, sorry, I did not move this comment along correctly with code I moved 😅 yeah it belongs to below!
| if (dsc) { | ||
| freezeDscOnSpan(span, dsc); | ||
| } |
There was a problem hiding this comment.
Just to check here but I think this is already how it works: Freezing only happens where we're continuing a trace (i.e. if a propagationContext with a DSC exists). In case it doesn't (i.e. we're head of trace || no DSC on propCtx), we don't freeze the DSC at all at the moment, correct? Meaning, we'd populate it for outgoing requests headers or when the span/txn is is processed.
There was a problem hiding this comment.
yes, dsc will only be set on the propagation context if we had an incoming trace, otherwise this will be undefined and we don't freeze it!
mydea
force-pushed
the
fn/transaction-metadata
branch
from
b8b731a to
21ba125
Compare
Instead, we freeze the DSC explicitly onto the transaction now. Apply suggestions from code review Co-authored-by: Lukas Stracke <[email protected]> fix comments fix linting
mydea
force-pushed
the
fn/transaction-metadata
branch
from
b0a881e to
00a8f25
Compare
|
Merging this in so I get more manageable merge conflicts |
Instead, we freeze the DSC explicitly onto the transaction now.
Instead, we freeze the DSC explicitly onto the transaction now.