Skip to content

feat(performance): add sampling rate to inp spans #10731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Feb 19, 2024

Updates INP spans to check for sampling rate, similar to transactions.

Requires the following PR:
#10709

….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
Copy link
Contributor

github-actions bot commented Feb 27, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.64 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.86 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.8 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.47 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.83 KB (+0.11% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 34.86 KB (+3.44% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.38 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.39 KB (0%)
@sentry/browser - Webpack (gzipped) 22.67 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.88 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.37 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.16 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 215.45 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 103.25 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.28 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.33 KB (+0.1% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.24 KB (+0.07% 🔺)
@sentry/react - Webpack (gzipped) 22.7 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.09 KB (+1.34% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.26 KB (+2.22% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.24 KB (0%)

edwardgou-sentry and others added 3 commits February 29, 2024 15:39
…P spans (#10849)

Adds profile id, replay id, and user to standalone INP spans.

User comes from the current scope.
Replay Id is retrieved from the relay integration module and calling getReplayId().
Profile Id is retrieved from getting the active transaction at the time of the interaction
Since profile id isn't added to the transaction until the transaction ends, we need to hold onto a reference to the transaction instead of trying to grab the profile id right away
@edwardgou-sentry edwardgou-sentry merged commit b515f8e into egou/v7/feat/create-interaction-spans-on-inp Feb 29, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/v7/feat/add-sampling-rate-to-inp-spans branch February 29, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants