Skip to content

feat: Remove hub from global, hub.run & hub utilities #10718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 19, 2024

This removes hub on the global, as well as getHubFromCarrier, hub.run(), and some hub utilities: getHubFromCarrier, ensureHubOnCarrier and setHubOnCarrier.

note that makeMain remains as a noop for now to not break vite-plugin v0.6.0 😿 We can remove this eventually.

This removes `getHubFromCarrier`, as well as `hub.run()`, and some hub utilities: `getHubFromCarrier`, `ensureHubOnCarrier` and `setHubOnCarrier`.
@mydea mydea requested a review from lforst February 19, 2024 12:36
@mydea mydea self-assigned this Feb 19, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.81 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.07 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.64 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.25 KB (-0.32% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.17 KB (-0.29% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.15 KB (-0.27% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.14 KB (-0.3% 🔽)
@sentry/browser - Webpack (gzipped) 22.4 KB (-0.39% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.17 KB (-0.14% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.68 KB (-0.15% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.59 KB (-0.37% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.71 KB (-0.43% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.62 KB (-0.25% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.11 KB (-0.33% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.86 KB (-0.26% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.41 KB (-0.13% 🔽)
@sentry/react - Webpack (gzipped) 22.43 KB (-0.41% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.88 KB (-0.13% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.09 KB (-0.2% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (-0.48% 🔽)

@mydea mydea merged commit 7362857 into develop Feb 19, 2024
@mydea mydea deleted the fn/remove-hub-on-acs branch February 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants