-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(performance): Adds span envelope and datacategory #10706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edwardgou-sentry
merged 5 commits into
v7
from
egou/v7/feat/add-span-envelope-and-datacategory
Feb 28, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2b84c46
Adds span envelope and datacategory
edwardgou-sentry b4b349c
Datacategory map
edwardgou-sentry 05c2393
update createSpanEnvelope to accept an array of spans
edwardgou-sentry 6947192
Merge branch 'v7' into egou/v7/feat/add-span-envelope-and-datacategory
edwardgou-sentry 3f0f558
fix bad import
edwardgou-sentry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import type { SpanEnvelope, SpanItem } from '@sentry/types'; | ||
import type { Span } from '@sentry/types'; | ||
import { createEnvelope } from '@sentry/utils'; | ||
|
||
/** | ||
* Create envelope from Span item. | ||
*/ | ||
export function createSpanEnvelope(spans: Span[]): SpanEnvelope { | ||
const headers: SpanEnvelope[0] = { | ||
sent_at: new Date().toISOString(), | ||
}; | ||
|
||
const items = spans.map(createSpanItem); | ||
return createEnvelope<SpanEnvelope>(headers, items); | ||
} | ||
|
||
function createSpanItem(span: Span): SpanItem { | ||
const spanHeaders: SpanItem[0] = { | ||
type: 'span', | ||
}; | ||
return [spanHeaders, span]; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.