Skip to content

ci: Warn on unused disabled directives #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Feb 12, 2024

Doesn't turn CI red yet, that would require a bit more effort but at least the eslint language server will scream at us now with warnings.

@lforst lforst requested review from mydea, Lms24 and AbhiPrasad February 12, 2024 12:44
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.9 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.13 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.05 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.74 KB (-0.32% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.31 KB (+0.11% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.16 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.17 KB (+0.04% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.16 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped) 22.44 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.88 KB (-0.25% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.43 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.38 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.48 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.61 KB (-0.29% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.16 KB (+0.13% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.57 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.62 KB (+0.24% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.49 KB (-0.27% 🔽)
@sentry/react - Webpack (gzipped) 22.47 KB (+0.07% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.31 KB (-0.14% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.42 KB (+0.13% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (-0.07% 🔽)

@lforst lforst merged commit ab410c6 into develop Feb 12, 2024
@lforst lforst deleted the lforst-warn-on-unused-disabled-directives branch February 12, 2024 13:08
s1gr1d added a commit that referenced this pull request Feb 22, 2024
Remove some unused directives to for less eslint warnings. Related to
#10610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants