Skip to content

docs: Fix deprecation message for span data/attributes #10608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

docs: Fix deprecation message for span data/attributes #10608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/tracing/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ export class SpanRecorder {
export class Span implements SpanInterface {
/**
* Tags for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
public tags: { [key: string]: Primitive };

/**
* Data for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
// eslint-disable-next-line @typescript-eslint/no-explicit-any
public data: { [key: string]: any };
Expand Down Expand Up @@ -263,7 +263,7 @@ export class Span implements SpanInterface {

/**
* Attributes for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
public get attributes(): SpanAttributes {
return this._attributes;
Expand Down
6 changes: 3 additions & 3 deletions packages/types/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,19 +226,19 @@ export interface Span extends Omit<SpanContext, 'op' | 'status' | 'origin'> {

/**
* Tags for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
tags: { [key: string]: Primitive };

/**
* Data for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
data: { [key: string]: any };

/**
* Attributes for the span.
* @deprecated Use `getSpanAttributes(span)` instead.
* @deprecated Use `spanToJSON(span).atttributes` instead.
*/
attributes: SpanAttributes;

Expand Down