Skip to content

test(browser-integration): Attempt to improve potentially flakey slowClick -> windowOpen test #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 6, 2024

Maybe closes #10377

@billyvg billyvg marked this pull request as ready for review February 6, 2024 22:24
@billyvg billyvg requested review from mydea and onurtemizkan February 6, 2024 22:24
@mydea mydea force-pushed the test-flakey-slowClick-windowOpen branch from 753ffa3 to 3f366fb Compare February 7, 2024 08:05
@AbhiPrasad
Copy link
Member

Going to merge this in because I hit this and I wanna see if it fixes it.

@AbhiPrasad AbhiPrasad merged commit 5022f2f into develop Feb 7, 2024
@AbhiPrasad AbhiPrasad deleted the test-flakey-slowClick-windowOpen branch February 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: replay/slowClick/windowOpen/test.ts:6:11 › window.open() is considered for slow click
3 participants