Skip to content

ref(nextjs): Remove internal deprecated usage of deepReadDirSync #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions packages/nextjs/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,5 @@ module.exports = {
project: ['../../tsconfig.dev.json'],
},
},
{
files: ['test/buildProcess/**'],
parserOptions: {
sourceType: 'module',
},
plugins: ['react'],
extends: ['../../.eslintrc.js', 'plugin:react/recommended'],
rules: {
// Prop types validation is not useful in test environments
'react/prop-types': 'off',
// Nextjs takes care of including react, so we don't explicitly need to
'react/react-in-jsx-scope': 'off',
},
},
],
};
4 changes: 1 addition & 3 deletions packages/nextjs/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,5 @@ const baseConfig = require('../../jest/jest.config.js');

module.exports = {
...baseConfig,
// This prevents the build tests from running when unit tests run. (If they do, they fail, because the build being
// tested hasn't necessarily run yet.)
testPathIgnorePatterns: ['<rootDir>/test/buildProcess/', '<rootDir>/test/integration/'],
testPathIgnorePatterns: ['<rootDir>/test/integration/'],
};
3 changes: 1 addition & 2 deletions packages/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@
"fix": "eslint . --format stylish --fix",
"lint": "eslint . --format stylish",
"test": "yarn test:unit",
"test:all": "run-s test:unit test:integration test:build",
"test:build": "yarn ts-node test/buildProcess/runTest.ts",
"test:all": "run-s test:unit test:integration",
"test:unit": "jest",
"test:integration": "./test/run-integration-tests.sh && yarn test:types",
"test:integration:clean": "(cd test/integration && rimraf .cache node_modules build)",
Expand Down
4 changes: 0 additions & 4 deletions packages/nextjs/test/buildProcess/jest.config.js

This file was deleted.

42 changes: 0 additions & 42 deletions packages/nextjs/test/buildProcess/runTest.ts

This file was deleted.

36 changes: 0 additions & 36 deletions packages/nextjs/test/buildProcess/testApp/.gitignore

This file was deleted.

25 changes: 0 additions & 25 deletions packages/nextjs/test/buildProcess/testApp/next.config.js

This file was deleted.

18 changes: 0 additions & 18 deletions packages/nextjs/test/buildProcess/testApp/package.json

This file was deleted.

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions packages/nextjs/test/buildProcess/testApp/src/dogs.json

This file was deleted.

5 changes: 0 additions & 5 deletions packages/nextjs/test/buildProcess/testApp/src/pages/_app.js

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions packages/nextjs/test/buildProcess/testApp/src/pages/index.js

This file was deleted.

Loading