Skip to content

ref(nextjs): Remove internal deprecated usage of deepReadDirSync #10129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jan 10, 2024

Removes usage of deepReadDirSync by removing the unused tests that call it.

Ref: #10100

@lforst lforst requested review from Lms24 and mydea January 10, 2024 10:52
@lforst lforst changed the title ref(nextjs): Remove internal usage of deepReadDirSync ref(nextjs): Remove internal deprecated usage of deepReadDirSync Jan 10, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the replacement for these tests are our e2e tests, correct?

@lforst lforst force-pushed the lforst-rem-deprecations-nextjs branch from 84ebf9f to 4f7d371 Compare January 10, 2024 11:11
@lforst
Copy link
Contributor Author

lforst commented Jan 10, 2024

I guess the replacement for these tests are our e2e tests, correct?

Originally we added these tests to ensure the Sentry CLI binary will not be included in AWS lambdas when deploying nextjs to vercel. We now have this test inside the CLI repository itself.

Copy link
Contributor

github-actions bot commented Jan 10, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.36 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.99 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.38 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.98 KB (0%)
@sentry/browser - Webpack (gzipped) 22.31 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.61 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.26 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.07 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.9 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 208.7 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 96.75 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.35 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.04 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.72 KB (0%)
@sentry/react - Webpack (gzipped) 22.35 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.37 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.5 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.01 KB (0%)

@lforst lforst merged commit 559b423 into develop Jan 10, 2024
@lforst lforst deleted the lforst-rem-deprecations-nextjs branch January 10, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants